27 replies to this topic

[samdeman22]

So I have a log system where I add lines to a file through an API, but when I want to print part of it I thought I'd be able to use fs.readLine() with a number to read a specific line, but it apparently doesn't work like that (it just reads the 'next' line?).

In short, I must add the entire log to the page, how do I split up the massive string so it can fit on the pages?

[SuicidalSTDz]

Do you have any code we can see to get a better understanding?

[samdeman22]

ok, I show you then

function printLog(log, fromLn, copies)
if open == true then
  error("Log must be ended before printing")
end


--printer setup

local side = nil
local sides = { 1 = "front", 2 = "back", 3 = "left", 4 = "right", 5 = "top", 6 = "bottom" }
local no = 1
for i = 1, 6 do
  if no == 1 then
   side = sides[no]
  elseif no == 2 then
   side = sides[no]
  elseif no == 3 then
   side = sides[no]
  elseif no == 4 then
   side = sides[no]
  elseif no == 5 then
   side = sides[no]
  elseif no == 6 then
   side = sides[no]
  else
   error("no printer found")
  end
end
local p = peripheral.wrap(side)
h = fs.open("log/"..log..".log", r)
local printstr = nil
for i = 1, fromLn do
  h.readLine()
end
printstr = h.readAll()
fs.close()
end

its not quite finished as you'll see (the actual printing part is missing)

[SuicidalSTDz]

samdeman22, on 06 March 2013 - 10:12 AM, said:

h = fs.open("log/"..log..".log", r)

When opening a file the mode must be in string format like so:

h = fs.open("log/"..log..".log", "r")

Also since you defined the file as "h", you must close it like so:

h.close()

I think storing all the data in a table then printing it will be your best bet

EDIT: "printing" should be indexing (Nub)

[Lyqyd]

You can read the entire file into a table, line by line, then index the table to retrieve the line you want.

[samdeman22]

Yeah, I'll reshape this based on what you guys say tomorrow and show you.

[SuicidalSTDz]

Sounds like a plan

[remiX]

You can store the whole thing in a string and use an awesome function made by TheOriginalBit which splits it into a table with the desired length of each line. You can find it in his Extended Library api. Check it out at the programs section.

[Lyqyd]

remiX, on 06 March 2013 - 05:52 PM, said:

You can store the whole thing in a string and use an awesome function made by TheOriginalBit which splits it into a table with the desired length of each line. You can find it in his Extended Library api. Check it out at the programs section.

If it is the same function I am thinking of, it was not written by him, but is actually an example function found in the PIL. The one I'm thinking of is the one that's been floating around the forums for quite some time. I simply don't wish it to be misattributed if that is the case.

[remiX]

Lyqyd, on 06 March 2013 - 06:23 PM, said:

remiX, on 06 March 2013 - 05:52 PM, said:

You can store the whole thing in a string and use an awesome function made by TheOriginalBit which splits it into a table with the desired length of each line. You can find it in his Extended Library api. Check it out at the programs section.

If it is the same function I am thinking of, it was not written by him, but is actually an example function found in the PIL. The one I'm thinking of is the one that's been floating around the forums for quite some time.  I simply don't wish it to be misattributed if that is the case.

Oh, sorry if that is the case. He has it licensed in his api and told me that he did make it.

[samdeman22]

Right I've left the printing part for a while, the rest of the code is completely buggering me... here's a pastebin http://pastebin.com/YHBpSVyG and here's the code...

--The Log API 1.1
runningProgram = "test"
function openLog(name)
h = fs.open("logs/"..name..".log", "a")
end
function closeLog()
h.close()
end
--function setRunningProgram(name)
-- runningProgram = name
--end
function generateLog() --will create the Dir "log" in the root and create a .log file based on the running program (if if is not already there)
if not fs.exists("log") then
  fs.mkDir("log")
end

if runningProgram == nil then
  error("program not specified")
end
  h = fs.open("logs/"..runningProgram..".log", "a")
  h.writeLine("--- The "..runningProgram.." event log ---")
  h.writeLine(" ")
  h.close()
end
 
function addEntry(type, str)
local time = os.time()
local day = os.day()
h.writeLine("["..day.."]".."["..time.."]".."["..type.."] | #"..str)
end
function startLog()
open = true
local time = os.time()
local day = os.day()
openLog()
h.writeLine("["..day.."]".."["..time.."] | #STARTING LOG")
end
function endLog()
open = false
local time = os.time()
local day = os.day()
h.writeLine("["..day.."]".."["..time.."] | #ENDING LOG")

end
function setPrinterSide(side)
printside = side
end
function printLog(log, fromLn, copies)
if open == true then
  error("Log must be ended before printing")
end
end

[samdeman22]

It comes up with an error "log:5:attempt to concatenate nil and string" in this case its talking about the line h = fs.open("logs/"..name..".log", "a") which is strange because it actually gets past that part EVERY time and outputs the generateLog() stuff into the log properly.

[samdeman22]

this is when calling log.openLog("test")

[Lyqyd]

The startLog function calls openLog with no parameters.

[samdeman22]

Thanks, that makes sense.

[samdeman22]

Ok, returning to the printLog function, I have got it so it reads the entire thing line by line into a table, now printing it in a way that looks good, eugh.

remiX, on 06 March 2013 - 05:52 PM, said:

You can store the whole thing in a string and use an awesome function made by TheOriginalBit which splits it into a table with the desired length of each line. You can find it in his Extended Library api. Check it out at the programs section.

what was the name of the function? there are too many to choose from!

[samdeman22]

also could someone make me a function that gets how many pages are needed based on the length of the string?

[samdeman22]

Right, I'm hoping this will be the final iteration of the printLog(log, side, fromLn, toLn) function

-- a function you cant access ;P
local function round(num idp)
  local mult = 10 ^ (idp or 0)
  return (math.floor(num * mult + 0.5) / mult)
end
function printLog(log, side, fromLn, toLn)
  if open == true then
    error("Log must be ended before printing")
  end
  if not fs.exists( "logs/"..log..".log") then
    error("Log does not exist")
  end
 
  h = fs.open("logs/"..log..".log", "r")
  page = {}
  while h.readLine() ~= nil do
    local ln = h.readLine()
    table.insert(page, ln)
  end
 
  p = peripheral.wrap(side)
  local paper = p.getPaperLevel()
  local ink = p.getInkLevel()
  local w, h = p.getPageSize()
 
  local doc = {}
  for i = fromLn, toLn do
    table.insert(doc, page[i])
  end
 
  local length = 0
  for i = 0, #doc do
    length = length + doc[i]
  end
 
  local size = w*h
  local pages = round(length/size, 0)
  if pages > paper then
    error("not enough paper")
  end
  if pages > ink then
    error("not enough ink")
  end
 
  for i = 0, #doc do
    p.write(doc[i])
  end
 
end

This looks good to me but on loading the API I get "bios:338: [string "log"]:59: ' ) ' expected". Why ?

[samdeman22]

ok, fixed the error as soon as I posted it *facepalm, I forgot a comma on the round(num, idp) function

[samdeman22]

ok, there are some things to do yet with the printer stuff will work on it tho!