27 replies to this topic

[Alcheya]

LordIkol, on 30 September 2013 - 07:16 AM, said:

Untested but should give you a clue about how it can work

Spoiler

rednet.open("right")
local running = true

local function atk()
while true do
if running == true then
turtle.attack()
print("attacking")
end
sleep(0.8)
end
end

local function switchit()
event, id, text = os.pullEvent()
if text == "on" then
running = true
elseif text =="off" then
running = false
print("Stop attack")
end
end

while true do
parallel.waitForAny(switchit,atk)
end
end

edit: corrected an error now it should work ;D

Yes, it works and works well, but any reason why it would be incredibly more laggy than the standard "while true do" turtle attack program?

(with the normal program and all my machines/etc running, I'm normally sitting at about 50 fps.. with them running I dropped down to 6/7, even in another dimension with no mobs spawned)

[Alcheya]

Yep, something is definitely not right there. 60 fps without, down to 40 fps while the code is running, but when they go into attack mode, instant 6 fps. Sad times.

[Wojbie]

I don't see how it could cause lag - I am using similar setup with more complicated code on turtles and more turtles - and no lag - what mods are you using/version of minecraft/SSP or SMP?

[Alcheya]

wojbie, on 30 September 2013 - 03:55 PM, said:

I don't see how it could cause lag - I am using similar setup with more complicated code on turtles and more turtles - and no lag - what mods are you using/version of minecraft/SSP or SMP?

I'm sorry about that.

Using FTB Unleashed 1.1.4 SSP, but you're right, I don't know whats causing it. I was using 8 turtles with attack loop just fine the other day, but I guess something I did in the last 2 days ruined CC. I tried just doing basic attack loop on 1 turtle and I go from 60-70 fps down to 20. Ugh..

[Engineer]

To the fps problem, I would suggest to make a more reliable setup. Make the mobs move to one place via water or something, and then have one or two turtles just killing them. Saves space in your world and it should save a lot of 'lag'.

Thats the point of a mob grinder, have it as easy as possible and kill it. With your current setup. how are you going to collect the loot while you have the grinder running? Then the turtle is similair to lava, only there is no xp dropped.

[LordIkol]

Hi there sorry have not much time at the moment

I checked my Code again and see that you can reduce it to one while loop cause the parralell is executed in a while true loop you dont need the loop in the atk function.
Depending on your setup you can play around with the sleep command a bit to increase performance.
to make it easier for you to play around with the delay i added the delay as argument
if you start your program without arguments the delay is 1 second. if you want to start it with another delay just use <yourprogramname> x
where x is delay between attacks in seconds

rednet.open("right")
local running = true
args = ... or 1

local function atk()
if running == true then
turtle.attack()
print("attacking")
sleep(tonumber(args))
else
print("wait for command")
sleep(10)
end
end

local function switchit()
event, id, text = os.pullEvent()
if text == "on" then
running = true
elseif text =="off" then
running = false
print("Stop attack")
end
end

while true do
parallel.waitForAny(switchit,atk)
end

Greets Loki

Edited by LordIkol, 02 October 2013 - 02:34 AM.

[keyboardhack]

do this

cake = true
while true do
os.startTimer(1)
e,s,msg,dis = os.pullEvent()
if (e == "timer" and cake == true) then
turtle.attack()
elseif e == "rednet_message" then
if msg == "stop attacking" then
  cake = false
elseif msg == "start attacking" then
  cake = true
end
end

will stop the turtels when it receives a rednet message saying "stop attacking" and start again when it receives a rednet message saying "start attacking"

[MudkipTheEpic]

The last

cake==true

needs to be:

cake=true