13 replies to this topic

[MemoryLeak21]

Well, this is embarassing. Here's my program:

--[[ Load API ]]--
os.loadAPI("redos")
--[[ Local Variables ]]--
local username
local password
local eUsername
local ePassword
local line
local file
local running = true
--[[ Main ]]--
while running do
  redos.clear()
  redos.header()
  file = fs.open("systemdata/first.txt", "r")
  line = file.readLine()
  file.close()

  if line == "true" then
	write("Register username: ")
	username = read()

	redos.clear()
	redos.header()

	write("Register password: ")
	password = read("*")

	if not fs.exists("userdata/"..username) then
	  fs.makeDir("userdata/"..username)
	  file = fs.open("userdata/"..username.."/password.txt", "w")
	  file.writeLine(password)
	  file.close()
	end

	file = fs.open("systemdata/first.txt", "w")
	file.writeLine("false")
	file.close()

	running = false

	redos.clear()
	redos.header()
  end

  write("Enter username: ")
  eUsername = read()

  redos.clear()
  redos.header()

  write("Enter password: ")
  ePassword = read("*")

  redos.clear()
  redos.header()

  if fs.exists("userdata/"..eUsername) then
	file = fs.open("userdata/"..eUsername.."/password.txt")
	line = fs.readLine()
	file.close()
	if line == ePassword then
	  print("Welcome,"..eUsername.."!")
	  os.sleep(1)
	  running = false
	end
  end
end

The code works fine until I enter the password for the system, and it gives me:

pass: 65: bad argument: string expected, got nil

I've run through all debugging methods I know of, and got zilch. Here's my system hierarchy:

systemdata > first.txt

userdata > MemoryLeak21 > password.txt

And my API just has header() and clear(), which do visual and unimportant things.

Anyone recognize the problem?

[ChunLing]

I'm not able to match line 65 with anything that would cause that. Can you use the edit program and post line 65 as it appears in the copy in CC?

[KaoS]

The only explanation I see is if 'eUsername' is nil however there is no situation in which that should occur, even if you do not enter anything for read it returns a blank string ("") perhaps your API is fiddling with your vars

[remiX]

Please specify within your code which line is line 65 so we know exactly and don't have to search through it. I copied it now into Notepad++ and my line 65 is 'running = false'

[MemoryLeak21]

I'm absolutely sure that the API isn't doing anything, as all it does is display the header or clear the screen. Here's my line 65:

        file = fs.open("userdata/"..eUsername.."/password.txt")

[Lyqyd]

Try specifying the mode to open the file with.

[MemoryLeak21]

Oh wow, I'm dumb as always. Thank you so much!

[KaoS]

lol, I feel just as stupid. blind lol

[ChunLing]

Don't feel bad, it's hard to spot an error when you're looking in the wrong place. I only checked about three lines up and down before giving up and asking for the exact line.

[ChaddJackson12]

Just a question, can you call empty variables? That might be your problem.

[MemoryLeak21]

Nah, I've called empty variables before in other programs and it's worked fine.

[ChaddJackson12]

MemoryLeak21, on 08 December 2012 - 08:34 AM, said:

Nah, I've called empty variables before in other programs and it's worked fine.

What's the point of calling an empty variable, though? That is, if they aren't a boolean value, or whatever those are...

[MemoryLeak21]

ChaddJackson12, on 08 December 2012 - 12:18 PM, said:

MemoryLeak21, on 08 December 2012 - 08:34 AM, said:

Nah, I've called empty variables before in other programs and it's worked fine.

What's the point of calling an empty variable, though? That is, if they aren't a boolean value, or whatever those are...

Well, I get used to organizing it that way so I have a quick reference of all the variables I'll be using in my program. It also avoids the creation of global variables, which are always messy.

[ChunLing]

The terminology there is "declare", not call. Declaring a variable without an assignment is perfectly valid (though I usually put them all on one line and assign nil, like: local username,password,eUsername,ePassword,line,file = nil just for clarity --though it's important that only the first one gets assigned that way). Calling a variable would usually mean either calling it as a function or passing it to a function as an argument. You usually want it to no longer be nil before doing either of those.