11 replies to this topic

[Dlcruz129]

Hey guys.

Here's the code for a screensaver code I'm writing. It is supposed to randomly draw pixels on the screen until a key is pressed. The problem is, it doesn't exit when you press a key, and cannot be terminated.

local maxX, maxY = term.getSize()
local count = 1
term.clear()
while true do
  local function screensaver()
    local xPos = math.random(1,maxX)
    local yPos = math.random(1,maxY)
    term.setCursorPos(xPos,yPos)
    local txtColor = 2^math.random(0,15)
    term.setBackgroundColor(txtColor)
    write(" ")
    count = count+1
    sleep(0.1)
    if count == 250 then
	  count = 1
	  term.setBackgroundColor(colors.black)
	  term.clear()
    end
  end
 
  local function exit()
    while true do
	  sleep(0.1)
	  event = os.pullEvent()
	  if event == "char" then
	    term.clear()
	    term.setCursorPos(1,1)
	    error()
	  end
    end
  end
  parallel.waitForAny(screensaver, exit)
end

Any help is appreciated. Thanks!

--Dlcruz

[theoriginalbit]

try this:

local maxX, maxY = term.getSize()
local count = 1
term.clear()
while true do
  event = os.pullEvent()

  local xPos = math.random(1,maxX)
  local yPos = math.random(1,maxY)
  term.setCursorPos(xPos,yPos)
  local txtColor = 2^math.random(0,15)
  term.setBackgroundColor(txtColor)
  write(" ")
  count = count + 1
  sleep(0.1)
  if count == 250 then
   count = 1
    term.setBackgroundColor(colors.black)
    term.clear()
  end

  if event == "key" then
   term.clear()
   term.setCursorPos(1,1)
   error()
  end
end

the problem was that you had the whole thing surrounded by a while loop.

[Dlcruz129]

 TheOriginalBIT, on 16 December 2012 - 07:50 PM, said:

try this:

local maxX, maxY = term.getSize()
local count = 1
term.clear()
while true do
  event = os.pullEvent()

  local xPos = math.random(1,maxX)
  local yPos = math.random(1,maxY)
  term.setCursorPos(xPos,yPos)
  local txtColor = 2^math.random(0,15)
  term.setBackgroundColor(txtColor)
  write(" ")
  count = count + 1
  sleep(0.1)
  if count == 250 then
   count = 1
	term.setBackgroundColor(colors.black)
	term.clear()
  end

  if event == "key" then
   term.clear()
   term.setCursorPos(1,1)
   error()
  end
end

the problem was that you had the whole thing surrounded by a while loop.

Nope, the screen just goes black. Then crashes with the error msg "11".

[theoriginalbit]

11? oh you mean it says something like "bios:some number [string "progname"] Error: 11: number expected" or some error message like that. yes thats because of this

2^math.random(0,15)

this isnt a valid colour.

[Dlcruz129]

 TheOriginalBIT, on 16 December 2012 - 07:57 PM, said:

11? oh you mean it says something like "bios:some number [string "progname"] Error: 11: number expected" or some error message like that. yes thats because of this

2^math.random(0,15)

this isnt a valid colour.

The program worked fine before. It raises 2 to a power of a random number between 0-15, therefore generating a random color. It simply prints "11" to the console. 11 means something special, I just can't remember what...

[theoriginalbit]

try putting shell.exit() instead of error?

[Dlcruz129]

 TheOriginalBIT, on 16 December 2012 - 08:02 PM, said:

try putting shell.exit() instead of error?

No. You should NEVER use shell.exit(). Its pretty much an alias for os.shutdown(). Please make sure you know what you are talking about before you try to help me.

[theoriginalbit]

Just trying to be helpful. As I cannot replicate the issue you are getting.

[theoriginalbit]

and fine, use return instead of error()

[Dlcruz129]

 TheOriginalBIT, on 16 December 2012 - 08:09 PM, said:

and fine, use return instead of error()

That fixed the exit part of the program, but the screensaver does not show up.

[theoriginalbit]

ohh oops. I see why. I missed the sleep in the code. sorry. disadvantage of typing it quick.

[theoriginalbit]

Fully functioning. Adds lots to the screen then resets after 5 seconds

Spoiler

local maxX, maxY = term.getSize()
local count = 1
local d = {}

resetTimer = os.startTimer(5)
addTimer = os.startTimer(0.1)

local function clear()
term.setBackgroundColor(colors.black)
term.clear()
term.setCursorPos(1,1)
end

while true do
event = { os.pullEventRaw() }

if event[1] == "key" then
clear()
return
elseif event[1] == "timer" then
if event[2] == addTimer then
t = {
["x"] = math.random(1,maxX),
["y"] = math.random(1,maxY),
["color"] = 2^math.random(0,15)
}

table.insert(d, t)
addTimer = os.startTimer(0.1)
elseif event[2] == resetTimer then
d = {}
resetTimer = os.startTimer(5)
end
end

clear()
for _, v in pairs( d ) do
term.setCursorPos( v["x"], v["y"] )
term.setBackgroundColor(v["color"])
write(" ")
end
end