Jump to content




disk instaler


15 replies to this topic

#1 rick3333

  • Members
  • 30 posts

Posted 23 December 2012 - 06:02 PM

this program is made for a disk not a computer

pastebin get UQqnACWz disk/startup

if you download the program change the startup file you want to install to os and test to the file name. the loading dose nothing it is just for looks

to use pastebin get you need to have the http_api enabled

(by the way this is my first program)

pastebin.com/UQqnACWz this is a link to the code on pastebin

Attached Files



#2 zekesonxx

  • Signature Abuser
  • 263 posts
  • LocationWhere you aren't

Posted 27 December 2012 - 02:50 AM

That, is horrible.

#3 rick3333

  • Members
  • 30 posts

Posted 01 January 2013 - 06:04 PM

View Postzekesonxx, on 27 December 2012 - 02:50 AM, said:

That, is horrible.
this is my first program give me a break

#4 FUCKCOMPUTERCRAFT!"£

  • Validating
  • 87 posts
  • LocationBasement

Posted 02 January 2013 - 08:34 AM

The title is spelt wrong, along with the code being horrible.

#5 nutcase84

  • Members
  • 711 posts
  • LocationIn My Lonely Little Computer Corner

Posted 02 January 2013 - 11:57 AM

IT'S HIS FIRST PROGRAM, give him a break.

#6 Kingdaro

    The Doctor

  • Members
  • 1,636 posts
  • Location'MURICA

Posted 02 January 2013 - 12:25 PM

None of you are helping. If you're going to call his code shit at least give criticism on how to improve it.

For example, instead of this
term.write("-")
sleep(0.3)
term.write("-")
sleep(0.3)
term.write("-")
sleep(0.3)
term.write("-")
sleep(0.3)
term.write("-")
sleep(0.3)
term.write("-")
sleep(0.3)
term.write("-")
sleep(0.3)

You could do this:
for i=1, 7 do
  term.write('-')
  sleep(0.3)
end

But fake loading times are usually more annoying than they are a novelty anyway.

#7 FUCKCOMPUTERCRAFT!"£

  • Validating
  • 87 posts
  • LocationBasement

Posted 02 January 2013 - 12:49 PM

Okay nutcase look at the code please... You'll then agree with me!

Improvements:

shell.run("clear")
print("thanks for choosing 'os name'")
sleep(1)
fs.delete("test")
fs.delete("test")
fs.delete("test")
fs.delete("test")
fs.copy("disk/test","test")
fs.copy("disk/os","startup")
fs.copy("disk/test1","test1")
fs.copy("disk/test2","test2")
term.write("-")
sleep(0.3)
term.write("-")
sleep(0.3)
term.write("-")
sleep(0.3)
term.write("-")
sleep(0.3)
term.write("-")
sleep(0.3)
term.write("-")
sleep(0.3)
term.write("-")
sleep(0.3)
print("-")
print("installed")
sleep(1)
print("programs has been installed.")
print("Shutting down the terminal.")
disk.eject("top")
disk.eject("bottom")
disk.eject("left")
disk.eject("right")
disk.eject("back")
disk.eject("front")
sleep(2)
shell.run("shutdown")

1. Use term.clear() instead of shell.run("clear") never heard of shell.run("clear") unless the owner has a program named as such on their PC
2. WTF do we need to do fs.delete("test") 4 times?!
3. Get rid of the installing progress bar, i wouldn't wanna wait...
4. Wtf you got to shutdown the PC after?
5. Adding some simple GUI couldn't do any harm...
6. Asking for user input so they dont have to edit the code if they want to use your program you can automaticlly do that through their input, eg

write("Side of the disk bay: ")
side = read()
disk.eject(side)

you could do this with the name of the files etc....

#8 Dlcruz129

    What's a Lua?

  • Members
  • 1,423 posts

Posted 02 January 2013 - 01:10 PM

View Postx0pk1n, on 02 January 2013 - 12:49 PM, said:

Okay nutcase look at the code please... You'll then agree with me!

Improvements:

shell.run("clear")
print("thanks for choosing 'os name'")
sleep(1)
fs.delete("test")
fs.delete("test")
fs.delete("test")
fs.delete("test")
fs.copy("disk/test","test")
fs.copy("disk/os","startup")
fs.copy("disk/test1","test1")
fs.copy("disk/test2","test2")
term.write("-")
sleep(0.3)
term.write("-")
sleep(0.3)
term.write("-")
sleep(0.3)
term.write("-")
sleep(0.3)
term.write("-")
sleep(0.3)
term.write("-")
sleep(0.3)
term.write("-")
sleep(0.3)
print("-")
print("installed")
sleep(1)
print("programs has been installed.")
print("Shutting down the terminal.")
disk.eject("top")
disk.eject("bottom")
disk.eject("left")
disk.eject("right")
disk.eject("back")
disk.eject("front")
sleep(2)
shell.run("shutdown")

1. Use term.clear() instead of shell.run("clear") never heard of shell.run("clear") unless the owner has a program named as such on their PC
2. WTF do we need to do fs.delete("test") 4 times?!
3. Get rid of the installing progress bar, i wouldn't wanna wait...
4. Wtf you got to shutdown the PC after?
5. Adding some simple GUI couldn't do any harm...
6. Asking for user input so they dont have to edit the code if they want to use your program you can automaticlly do that through their input, eg

write("Side of the disk bay: ")
side = read()
disk.eject(side)

you could do this with the name of the files etc....
The "clear" program comes standard in CC. That line of code works perfectly. I even use it sometimes when I'm too lazy to define function clear() :P

#9 rick3333

  • Members
  • 30 posts

Posted 13 January 2013 - 08:54 PM

View Postx0pk1n, on 02 January 2013 - 12:49 PM, said:

Okay nutcase look at the code please... You'll then agree with me!

Improvements:

shell.run("clear")
print("thanks for choosing 'os name'")
sleep(1)
fs.delete("test")
fs.delete("test")
fs.delete("test")
fs.delete("test")
fs.copy("disk/test","test")
fs.copy("disk/os","startup")
fs.copy("disk/test1","test1")
fs.copy("disk/test2","test2")
term.write("-")
sleep(0.3)
term.write("-")
sleep(0.3)
term.write("-")
sleep(0.3)
term.write("-")
sleep(0.3)
term.write("-")
sleep(0.3)
term.write("-")
sleep(0.3)
term.write("-")
sleep(0.3)
print("-")
print("installed")
sleep(1)
print("programs has been installed.")
print("Shutting down the terminal.")
disk.eject("top")
disk.eject("bottom")
disk.eject("left")
disk.eject("right")
disk.eject("back")
disk.eject("front")
sleep(2)
shell.run("shutdown")

1. Use term.clear() instead of shell.run("clear") never heard of shell.run("clear") unless the owner has a program named as such on their PC
2. WTF do we need to do fs.delete("test") 4 times?!
3. Get rid of the installing progress bar, i wouldn't wanna wait...
4. Wtf you got to shutdown the PC after?
5. Adding some simple GUI couldn't do any harm...
6. Asking for user input so they dont have to edit the code if they want to use your program you can automaticlly do that through their input, eg

write("Side of the disk bay: ")
side = read()
disk.eject(side)

you could do this with the name of the files etc....
you can remove the loading bar if you want

#10 BustedEarLobes

  • Members
  • 46 posts

Posted 13 January 2013 - 10:13 PM

View Postx0pk1n, on 02 January 2013 - 12:49 PM, said:

Okay nutcase look at the code please... You'll then agree with me!

Improvements:

shell.run("clear")
print("thanks for choosing 'os name'")
sleep(1)
fs.delete("test")
fs.delete("test")
fs.delete("test")
fs.delete("test")
fs.copy("disk/test","test")
fs.copy("disk/os","startup")
fs.copy("disk/test1","test1")
fs.copy("disk/test2","test2")
term.write("-")
sleep(0.3)
term.write("-")
sleep(0.3)
term.write("-")
sleep(0.3)
term.write("-")
sleep(0.3)
term.write("-")
sleep(0.3)
term.write("-")
sleep(0.3)
term.write("-")
sleep(0.3)
print("-")
print("installed")
sleep(1)
print("programs has been installed.")
print("Shutting down the terminal.")
disk.eject("top")
disk.eject("bottom")
disk.eject("left")
disk.eject("right")
disk.eject("back")
disk.eject("front")
sleep(2)
shell.run("shutdown")

1. Use term.clear() instead of shell.run("clear") never heard of shell.run("clear") unless the owner has a program named as such on their PC
2. WTF do we need to do fs.delete("test") 4 times?!
3. Get rid of the installing progress bar, i wouldn't wanna wait...
4. Wtf you got to shutdown the PC after?
5. Adding some simple GUI couldn't do any harm...
6. Asking for user input so they dont have to edit the code if they want to use your program you can automaticlly do that through their input, eg

write("Side of the disk bay: ")
side = read()
disk.eject(side)

you could do this with the name of the files etc....

Wow. Dude grow up! It's called constructive criticism. You are completely ridiculous, and I guarantee you were in his shoes when you first started out. Your tone is beyond disrespectful, and people like you shouldn't even be on this forum. Want to teach someone how to run a program right? Then do it in a tone that doesn't make you look like an ass...

#11 brett122798

  • Members
  • 298 posts
  • LocationIn the TARDIS at an unknown place in time.

Posted 14 January 2013 - 06:39 PM

View PostBustedEarLobes, on 13 January 2013 - 10:13 PM, said:

Wow. Dude grow up! It's called constructive criticism. You are completely ridiculous, and I guarantee you were in his shoes when you first started out. Your tone is beyond disrespectful, and people like you shouldn't even be on this forum. Want to teach someone how to run a program right? Then do it in a tone that doesn't make you look like an ass...
This guy shouldn't be posting a program that has almost no use and is poorly coded in Programs then. The better idea would be to go to Ask A Pro and get help there to make USEFUL programs.

#12 crazyguymgd

  • Members
  • 139 posts
  • LocationUSA

Posted 14 January 2013 - 06:47 PM

I remember the first thing I did in terms of programming was create a simple webpage in html back in 2003. It said Hi Matt! and linked to some of my favorite flash games. Point is I was super proud of that webpage, even though it was poorly made and served no purpose, and I showed it to everyone!
Rick3333, you have a long way to go but nice job on picking a project and finishing it. Now take these guys (the ones that weren't assholes) advice, modify your project and keep making it better. If you have any other questions just ask!

#13 unstopablekk

  • Members
  • 50 posts

Posted 14 January 2013 - 07:02 PM

Damn, why is everyone so rude and disrespectful on the forums. I understand the whole "Criticism" thing but some of you are taking it too far. I'm new at this as well and i'm afraid to even post my work on here which is a loss to the community as a whole. I want you to look at a Lua Pro's profile and show me the work they did when they first joined. Granted, the code may not serve a purpose but it was something to show, something of pride. The best way to criticize is with respect, and if this community looses all sence of respect then I see little of this community as a whole.
Anyway...
Great work rick3333. Take the advice but keep in mind that whatever you do, and where ever you do it, you will have ass-holes like these criticize your work when this may be exactly how they started.

#14 theoriginalbit

    Semi-Professional ComputerCrafter

  • Moderators
  • 7,332 posts
  • LocationAustralia

Posted 14 January 2013 - 07:21 PM

View Postunstopablekk, on 14 January 2013 - 07:02 PM, said:

I want you to look at a Lua Pro's profile and show me the work they did when they first joined.

Yeh mine was pretty terrible... having to learn Lua, and all its differences... and over time with practise, constructive criticism, experimenting, and the "Ask a Pro" section you get better and better.
For all you guys know, rick3333 could become extremely good and bring us the next Lightroom, or NPaintPro, or Firewolf, or anything else that you can think of that you personally find exceptional, and by treating him the way you are you could very well be discouraging him from developing this program... so say something nice, and constructive or don't say anything at all...

Keep up the good work rick3333 and I hope to see what else you make in the future.

Edited by TheOriginalBIT, 14 January 2013 - 09:08 PM.


#15 rick3333

  • Members
  • 30 posts

Posted 02 February 2013 - 11:10 PM

View Postx0pk1n, on 02 January 2013 - 12:49 PM, said:

Okay nutcase look at the code please... You'll then agree with me!

Improvements:

shell.run("clear")
print("thanks for choosing 'os name'")
sleep(1)
fs.delete("test")
fs.delete("test")
fs.delete("test")
fs.delete("test")
fs.copy("disk/test","test")
fs.copy("disk/os","startup")
fs.copy("disk/test1","test1")
fs.copy("disk/test2","test2")
term.write("-")
sleep(0.3)
term.write("-")
sleep(0.3)
term.write("-")
sleep(0.3)
term.write("-")
sleep(0.3)
term.write("-")
sleep(0.3)
term.write("-")
sleep(0.3)
term.write("-")
sleep(0.3)
print("-")
print("installed")
sleep(1)
print("programs has been installed.")
print("Shutting down the terminal.")
disk.eject("top")
disk.eject("bottom")
disk.eject("left")
disk.eject("right")
disk.eject("back")
disk.eject("front")
sleep(2)
shell.run("shutdown")

1. Use term.clear() instead of shell.run("clear") never heard of shell.run("clear") unless the owner has a program named as such on their PC
2. WTF do we need to do fs.delete("test") 4 times?!
3. Get rid of the installing progress bar, i wouldn't wanna wait...
4. Wtf you got to shutdown the PC after?
5. Adding some simple GUI couldn't do any harm...
6. Asking for user input so they dont have to edit the code if they want to use your program you can automaticlly do that through their input, eg

write("Side of the disk bay: ")
side = read()
disk.eject(side)

you could do this with the name of the files etc....
shell.run("clear") is easier way of clearing the termanal

#16 theoriginalbit

    Semi-Professional ComputerCrafter

  • Moderators
  • 7,332 posts
  • LocationAustralia

Posted 03 February 2013 - 02:34 AM

View Postrick3333, on 02 February 2013 - 11:10 PM, said:

shell.run("clear") is easier way of clearing the termanal
Easier yes, best NO! It runs a program, what if they changed the program to do something else, its best to use the native functions over an existing program!





1 user(s) are reading this topic

0 members, 1 guests, 0 anonymous users