17 replies to this topic

[FUCKCOMPUTERCRAFT!"£]

Hey, i was testing my program and have no idea why it isn't working. Any ideas on why would be helpful as i have no idea after receiving the same error again and again...

http://pastebin.com/yKxec9R9

[theoriginalbit]

Please more information. What is the error?

[remiX]

I'm not sure how you're trying to make your menus but you can't set a variable to the name of a function and try call it.

[FUCKCOMPUTERCRAFT!"£]

Well it doesn't move up or down and when i hit enter it does nothing, but looking at the code im sure it should :L

remiX, on 04 January 2013 - 01:34 AM, said:

I'm not sure how you're trying to make your menus but you can't set a variable to the name of a function and try call it.

You can, try it....

function test12345()
print("You're gona be surprised")
end
current = test12345
current()

[remiX]

Yeah nevermind, I had a brain fart. I've actually done it before in my codes before. Wasn't thinking haha.

But the way you're making the menu systems is weird, you should use a table with the options and then print the options.

Example:

local function menu(_table)
    local sel = 1
    local offX,offY = term.getCursorPos()
    local curX,curY = term.getCursorPos()
    while true do
		    if sel > #_table then sel = 1 end
		    if sel < 1 then sel = #_table end
		    for i = 1,#_table do
				    term.setCursorPos(offX,offY+i-1)
				    if sel == i then
						    print("[".._table[i].."]")
				    else
						    print(" ".._table[i].." ")
				    end
		    end
		    local e, key = os.pullEvent("key")
		    if key == 200 then -- up key
				    sel = sel-1
		    elseif key == 208 then -- down key
				    sel = sel+1
		    elseif key == 28 then
				    term.setCursorPos(curX,curY)
				    return _table[sel], sel
		    end
    end
end

-- Table with options
tab = {"Option 1", "Option 2"}

-- Call it like this
selection = menu(tab)
if selection == tab[1] then
-- Option 1 was selected
elseif selection == tab[2] then
-- Option 2 was selected
end

[FUCKCOMPUTERCRAFT!"£]

[FUCKCOMPUTERCRAFT!"£]

remiX, on 04 January 2013 - 02:59 AM, said:

Yeah nevermind, I had a brain fart. I've actually done it before in my codes before. Wasn't thinking haha.

But the way you're making the menu systems is weird, you should use a table with the options and then print the options.

Example:

local function menu(_table)
	local sel = 1
	local offX,offY = term.getCursorPos()
	local curX,curY = term.getCursorPos()
	while true do
			if sel > #_table then sel = 1 end
			if sel < 1 then sel = #_table end
			for i = 1,#_table do
					term.setCursorPos(offX,offY+i-1)
					if sel == i then
							print("[".._table[i].."]")
					else
							print(" ".._table[i].." ")
					end
			end
			local e, key = os.pullEvent("key")
			if key == 200 then -- up key
					sel = sel-1
			elseif key == 208 then -- down key
					sel = sel+1
			elseif key == 28 then
					term.setCursorPos(curX,curY)
					return _table[sel], sel
			end
	end
end

-- Table with options
tab = {"Option 1", "Option 2"}

-- Call it like this
selection = menu(tab)
if selection == tab[1] then
-- Option 1 was selected
elseif selection == tab[2] then
-- Option 2 was selected
end

I was gona use table but i don't understand them, tried looking at tutorials but didn't get it...

Even still should my code not work? even if it is werid?!?

[remiX]

I'll take a harder look at your code and try find what's wrong but you do not need a function to highlight which option is selected.

WIth the code I gave you, you don't even need to tables:

local function menu(...)
		local sel = 1
		list = {...}
		local offX,offY = term.getCursorPos()
		local curX,curY = term.getCursorPos()
		while true do
						if sel > #list then sel = 1 end
						if sel < 1 then sel = #list end
						for i = 1,#list do
										term.setCursorPos(offX,offY+i-1)
										if sel == i then
														print("["..list[i].."]")
										else
														print(" "..list[i].." ")
										end
						end
						local e, key = os.pullEvent("key")
						if key == 200 then -- up key
										sel = sel-1
						elseif key == 208 then -- down key
										sel = sel+1
						elseif key == 28 then
										term.setCursorPos(curX,curY)
										return list[sel], sel
						end
		end
end

-- Call it like this
selection, number = menu("Option 1", "Option 2")
if selection == "Option 1" then -- You can also use the 'number' variable, here it would be 1
-- Option 1 was selected
elseif selection == "Option 2" then -- number will be 2
-- Option 2 was selected
end

Edit: Remove these lines from each of the last 3 functions with os.pullEvent

        if event == "key" then 
        else
                current()
        end
        if key ~= 28 or 200 or 208 then
                current()
        end  

And then when you make mMselection = 2, there is no if statement for if it is 2.

Also, you can use if elseif else end, instead of each block being an if statement.

[FUCKCOMPUTERCRAFT!"£]

remiX, on 04 January 2013 - 05:50 AM, said:

I'll take a harder look at your code and try find what's wrong but you do not need a function to highlight which option is selected.

WIth the code I gave you, you don't even need to tables:

local function menu(...)
		local sel = 1
		list = {...}
		local offX,offY = term.getCursorPos()
		local curX,curY = term.getCursorPos()
		while true do
						if sel > #list then sel = 1 end
						if sel < 1 then sel = #list end
						for i = 1,#list do
										term.setCursorPos(offX,offY+i-1)
										if sel == i then
														print("["..list[i].."]")
										else
														print(" "..list[i].." ")
										end
						end
						local e, key = os.pullEvent("key")
						if key == 200 then -- up key
										sel = sel-1
						elseif key == 208 then -- down key
										sel = sel+1
						elseif key == 28 then
										term.setCursorPos(curX,curY)
										return list[sel], sel
						end
		end
end

-- Call it like this
selection, number = menu("Option 1", "Option 2")
if selection == "Option 1" then -- You can also use the 'number' variable, here it would be 1
-- Option 1 was selected
elseif selection == "Option 2" then -- number will be 2
-- Option 2 was selected
end

Edit: Remove these lines from each of the last 3 functions with os.pullEvent

		if event == "key" then
		else
				current()
		end
		if key ~= 28 or 200 or 208 then
				current()
		end  

And then when you make mMselection = 2, there is no if statement for if it is 2.

Also, you can use if elseif else end, instead of each block being an if statement.

I've just realised all the 0 should be 2 in the if statements...

Also why remove these functions? They are needed to ensure other event aren't interfering and that they entered valid keys...

[remiX]

Then surround the code in an 'if event == "key" then' statement.
Also, I used elseif's here so you can see how it's used:

function mMenuKI()
    event , key = os.pullEvent()
    -- Surround the code within an if statement
    if event == "key" then
        if key == 28 then--ENTER KEY
            if mMselction == 1 then --SELECTED E-Mail Network
                EMailNetworkMenu()
            elseif mMselction == 2 then --SELECTED Exit
                exitP()
            end
        elseif key == 200 and mMselction == 1 then --ARROW KEY
            mMenu()
        elseif key == 200 and mMselction == 2 then --ARROW KEY
            mMenu()
        elseif key == 208 and mMselction == 1 then --ARROW KEY
            mvMenu()
        elseif key == 208 and mMselction == 2 then --ARROW KEY
            mvMenu()
        end
    end
end

[FUCKCOMPUTERCRAFT!"£]

remiX, on 04 January 2013 - 06:27 AM, said:

Then surround the code in an 'if event == "key" then' statement.
Also, I used elseif's here so you can see how it's used:

function mMenuKI()
	event , key = os.pullEvent()
	-- Surround the code within an if statement
	if event == "key" then
		if key == 28 then--ENTER KEY
			if mMselction == 1 then --SELECTED E-Mail Network
				EMailNetworkMenu()
			elseif mMselction == 2 then --SELECTED Exit
				exitP()
			end
		elseif key == 200 and mMselction == 1 then --ARROW KEY
			mMenu()
		elseif key == 200 and mMselction == 2 then --ARROW KEY
			mMenu()
		elseif key == 208 and mMselction == 1 then --ARROW KEY
			mvMenu()
		elseif key == 208 and mMselction == 2 then --ARROW KEY
			mvMenu()
		end
	end
end

No idea what on earth you have done but it works

Im now just changing the code a bit to get what i want ill post if i don't understand something or have hit a brick wall...

[FUCKCOMPUTERCRAFT!"£]

I think Lua just doesn't like me :L Nothing ever seems to work...

---------------------------------------
--MAIN MENU KEY INTERACTION
function mMenuKI()
	event , key = os.pullEvent()
	-- Surround the code within an if statement
	if event == "key" then
               if key ~= 28 or 200 or 208 then
                       current()
               elseif key == 28 then--ENTER KEY
			if mMselction == 1 then --SELECTED E-Mail Network
				EMailNetworkMenu()
			elseif mMselction == 2 then --SELECTED Exit
				exitP()
			end
		elseif key == 200 and mMselction == 1 then --ARROW KEY
			mMenu()
		elseif key == 200 and mMselction == 2 then --ARROW KEY
			mMenu()
		elseif key == 208 and mMselction == 1 then --ARROW KEY
			mvMenu()
		elseif key == 208 and mMselction == 2 then --ARROW KEY
			mvMenu()						  
		end
	end
end
----------------------------------------

When adding in the if statement so if they hit like f it does nothing (Which doesn't stop them i just tried...) it now also means you can't use the arrow keys i tried implimenting it diffrent ways but it just doesn't work...

[remiX]

if key ~= 28 or key ~= 200 or key ~= 208 then

But you don't need that! The one I posted should work fine.

[FUCKCOMPUTERCRAFT!"£]

remiX, on 04 January 2013 - 07:43 AM, said:

if key ~= 28 or key ~= 200 or key ~= 208 then

But you don't need that! The one I posted should work fine.

I copy and pasted it in and erased mine and yes it worked i can hit any key and it just exits...

[remiX]

Add a while true do loop then

function mMenuKI()
while true do
        event , key = os.pullEvent()
        -- Surround the code within an if statement
        if event == "key" then
                if key == 28 then--ENTER KEY
                        if mMselction == 1 then --SELECTED E-Mail Network
                                EMailNetworkMenu()
                        elseif mMselction == 2 then --SELECTED Exit
                                exitP()
                        end
                elseif key == 200 and mMselction == 1 then --ARROW KEY
                        mMenu()
                elseif key == 200 and mMselction == 2 then --ARROW KEY
                        mMenu()
                elseif key == 208 and mMselction == 1 then --ARROW KEY
                        mvMenu()
                elseif key == 208 and mMselction == 2 then --ARROW KEY
                        mvMenu()
                end
        end
end
end

Problem solved

[FUCKCOMPUTERCRAFT!"£]

Okay so what was the problem with my code? Why couldn't what i had be used???

[remiX]

I think it's because you used the or wrong,
you used

if key ~= 29 or 200 or ...

but it should be

 if key ~= 29 or key ~= 200 ...

[FUCKCOMPUTERCRAFT!"£]

remiX, on 04 January 2013 - 08:27 AM, said:

I think it's because you used the or wrong,
you used

if key ~= 29 or 200 or ...

but it should be

 if key ~= 29 or key ~= 200 ...

Ahh okay Thanks for your help I'm sure ill confuse myself again later...