11 replies to this topic

[grand_mind1]

I am trying to write a simple refuel function to call in some of my turtle programs to make sure my turtles don't run out of fuel or start without enough fuel. My code looks perfectly fine to me and when I run it I don't get any errors, but it just does nothing. I run the program and nothing happens. Would someone mind telling me what I've done wrong and what I can do to fix it? This is probably some simple mistake on my part since I am very much a beginner with Lua and computercraft. I appreciate all help and thank you in advance!
Thanks!

function checkFuel()
  m = turtle.getFuelLevel()
  n = 100000 - m
  if m < 100000 then
    print("I need ", n ," more fuel")
    print("Waiting for Fuel...")
    repeat
	  turtle.refuel()
    until m > 100000
    print("Got my fuel!")
  else
    print("I don't need fuel!")
  end
end

[theoriginalbit]

Ok so your problems:

• you were never rechecking the fuel, so really even if it hit the right level it wouldn't have known
  
• turtle.refuel only works on the selected slot, you need to check them all with a loop

local function checkFuel()
  while turtle.getFuelLevel() < 100000 do
	print( "I need "..( 100000 - turtle.getFuelLevel() ).." more fuel" )
	print( "Checking for fuel..." )
	for i = 1, 16 do
	  turtle.select( i )
	  turtle.refuel()
	end
	print( "Checked for fuel..."
  end
  print( "I have got enough fuel...")
end

Edited by TheOriginalBIT, 18 January 2013 - 02:22 AM.

[grand_mind1]

TheOriginalBIT, on 17 January 2013 - 03:01 PM, said:

Ok so your problems:

• you were never rechecking the fuel, so really even if it hit the right level it wouldn't have known
  
• turtle.refuel only works on the selected slot, you need to check them all with a loop

local function checkFuel()
  while turtle.getFuelLevel() < 100000 do
	print( "I need "..( 100000 - turtle.getFuelLeve() ).." more fuel" )
	print( "Checking for fuel..." )
	for i = 1, 16 do
	  turtle.select( i )
	  turtle.refuel()
	end
	print( "Checked for fuel..."
  end
  print( "I have got enough fuel...")
end

While I do thank you for the help this still has the same problem. When I run the program nothing happens.

[theoriginalbit]

you have to call the function with this

checkFuel()

[grand_mind1]

TheOriginalBIT, on 17 January 2013 - 03:21 PM, said:

you have to call the function with this

checkFuel()

I'm soooooo dumb......

[Dlcruz129]

grand_mind1, on 17 January 2013 - 03:26 PM, said:

TheOriginalBIT, on 17 January 2013 - 03:21 PM, said:

you have to call the function with this

checkFuel()

I'm soooooo dumb......

Don't worry, you'll catch on. It can be tricky learning a new programming language.

[remiX]

TheOriginalBIT, on 17 January 2013 - 03:01 PM, said:

Ok so your problems:

• you were never rechecking the fuel, so really even if it hit the right level it wouldn't have known
  
• turtle.refuel only works on the selected slot, you need to check them all with a loop

local function checkFuel()
  while turtle.getFuelLevel() < 100000 do
	print( "I need "..( 100000 - turtle.getFuelLeve() ).." more fuel" )
	print( "Checking for fuel..." )
	for i = 1, 16 do
	  turtle.select( i )
	  turtle.refuel()
	end
	print( "Checked for fuel..."
  end
  print( "I have got enough fuel...")
end

Does selecting or refueling yield?

[theoriginalbit]

remiX, on 18 January 2013 - 02:21 AM, said:

Does selecting or refueling yield?

I'm not actually too sure about that... although I'm sure if it didn't we would have known since 11 hours have passed...

[Cloudy]

Selecting does.

[remiX]

TheOriginalBIT, on 18 January 2013 - 02:23 AM, said:

remiX, on 18 January 2013 - 02:21 AM, said:

Does selecting or refueling yield?

I'm not actually too sure about that... although I'm sure if it didn't we would have known since 11 hours have passed...

Or his turtle had over 100000 fuel ever since

[theoriginalbit]

And there we go... we now know

Cloudy is there a list compiled somewhere that contains all the CC API function calls that yield?

[ChunLing]

It's easier to list the ones that don't. If you look in the turtle API Lua code, only the functions that have been reverted to match the native versions will fail to yield. All the other's are automatically replaced with versions that yield until the native function sends back an event.

turtle["getItemCount"] = native.getItemCount
turtle["getItemSpace"] = native.getItemSpace
turtle["getFuelLevel"] = native.getFuelLevel

Edited by ChunLing, 18 January 2013 - 12:50 PM.