pugsx, on 12 April 2015 - 02:43 PM, said:

The name just might not be right depending on what mods you have installed. If you tell me the network name of the reactor then I can change the script to match. I actually never tested the reactor, I just know it follows the same rules as the Turbine and I tested a Turbine.

Also, make sure it's not just connected to the Reactor itself, it has to be connected to a Reactor Computer Port.

Alright, I'm done, the rewrite is complete and I did a few testing rounds. I updated the Changelog and program Pastebin uploads and I updated the main post (still need to take new pictures). Everything should be up to date and operational. Please let me know if you encounter any further problems or have any suggestions.

Update: I spoke to the dev of Computronics and he informed me that the reason the script can't get the correct values for Capacitor Banks is because OpenPeripherals doesn't have support for the way Capacitor Banks handle RF values but Computronics does, which explains why it worked for me in the first place.

So what this means is that I'll have to require Computronics for the script to work properly with Capacitor Banks. I can code support for both Computronics and OpenPeripheral names but if anyone has OpenPeripherals without Computronics they won't be able to get the correct values from Capacitor Banks. In that event I'll put a variable in the code for someone to manually specify how many Capacitor Bank blocks are in their multiblock structure, which comes with obvious problems, but it's the best they can get without Computronics.

I'll work on the rewrite tonight and should have it done within a few hours.

Kaidenyo, on 03 April 2015 - 07:33 AM, said:

Well, I got it working with the new names, but now I'm having the same problem you had. It only reads from the block it's connected to with the Capacitor Banks

Kaidenyo, on 02 April 2015 - 05:50 PM, said:

Yours sounds like a much more reliable naming system, I wish mine worked like that. I've asked in a few places and nobody seems to have any idea why/how this could be happening. But I'll keep searching.

Update 1:

AHA! I figured it out! I removed three of the mods you didn't have on your server, immibis' peripherals, OpenCCSensors and Computronics and that fixed it. Now I just need to add them back in 1 by 1 to find out which mod it is that messes it up.

Update 2:

Yep, I found it. Look at this inside Computronics config file:

computercraft {

    ##########################################################################################################
    # multiperipheral
    #--------------------------------------------------------------------------------------------------------#
    # If all of these options are set to true, Computronics will fix almost every conflict with multiple mods adding peripherals to the same block
    ##########################################################################################################

    multiperipheral {
        # Set this to true to fix multiple mods adding peripherals to the same block not working [default: true]
        B:allMultiPeripherals=true

        # If this is true, the Computronics MultiPeripheral system will almost always be the one recognized by ComputerCraft [default: true]
        B:alwaysFirstPeripheral=true

        # Set this to false to disable MultiPeripheral compatibility with OpenPeripheral peripherals [default: true]
        B:openMultiPeripheral=true
    }

}

It looks like if I just set B:openMultiPeripheral=false it should fix the issue.

Update 3:

Nope, none of the config setting made a difference, you have to remove computronics entirely in order for the names to go back to normal. I'll just have to mark the script as incompatible with Computronics.

I'm currently working on rewriting the code to properly get the new types. It's a fair amount more difficult than before since there are more valid names. I could list all of them but I'd rather sort them by class which will require some pattern matching.

Kaidenyo, on 02 April 2015 - 07:36 AM, said:

Hmm, can you check all of the peripheral names for me? Are you getting different types assigned to everything or just capacitor banks? The ones on my world are "powered_tile" (applies to both TE Energy Cells and Mekanism Energy Cubes, possibly others as well), and "BigReactors_Turbine".

Also, are you saying that if you have a 38 block capacitor bank, it's assigning a different network name to every block in the capacitor bank? That's very strange, especially since you have the exact same versions of Computercraft, OpenPI, and EnderIO as I do.

Oh, and I can't believe I didn't ask this earlier: Why does your capacitor bank have an Input/Output screen on it?

Lupus590, on 01 April 2015 - 01:20 PM, said:

I haven't tried more than one connected network (mostly because I can't think of a reason to have more than one), but theoretically it shouldn't make a difference, computers can connect to more than one network at a time, even across separate networks all device names should still be unique and there's nothing in the code limiting it to only one network, so the script should recognize and connect to everything.

isaokirito, on 01 April 2015 - 10:16 PM, said:

I put how to do it in the Changelog/Readme posted here: http://pastebin.com/erPf3t4t

Here is what is says:

Quote

Lupus590, on 01 April 2015 - 01:20 PM, said:

I haven't tried more than one connected network (mostly because I can't think of a reason to have more than one), but theoretically it shouldn't make a difference, computers can connect to more than one network at a time, all device names should still be unique. There's nothing in the code limiting it to only one network.

Kaidenyo, on 01 April 2015 - 08:29 PM, said:

Let me make sure I have an official version of the program uploaded to Pastebin, I tend to upload testing versions to it for easy importing to Computercraft, I'll have to be sure to use a separate Pastebin upload for that from now on.

Also, I'd like to know why your peripheral name was different. I don't know what assigns those names. But that's why I posted all my mod versions, so people could compare theirs to mine and let me know so I can figure out which versions require a code change.

Also, it's strange that the program only counts the energy in one block of the Cap. Bank because it reads the entire thing for mine no matter what block I connect it to and no matter how large the capacitor bank is. Are you sure you're on the same mod versions? This problem is pretty bizarre.

Update: After some research it looks like it's OpenPeripherals that assigns types to everything aside from core Computercraft Peripherals, so that is what would have to be the same version as mine in order to work.

Let me test something: I'm going to install the standalone versions of OpenPeripherals instead of the AllInOne version and see if that makes a difference.

Update 2: It didn't make a difference, every peripheral still has the same peripheral.getType() return for me as it did before.

Also, I checked the version uploaded to Pastebin and it's a correct version, there shouldn't be any extraneous bugs in it.

Description:

A script designed to monitor Energy Cells and Capacitor Banks and turn engines/reactors/turbines on/off depending on energy levels. This is designed to be fully configurable and expandable.

Requires Computronics or OpenPeripheralsIntegration!

Images:

Features:

• Dynamically controls engines, turbines and reactors based on how much energy is stored in connected energy storage blocks.
  
• Energy values at which to turn engines on and off are easily configurable.
  
• Can output redstone to any side or no side with easy configuration. (For controlling engines)
  
• Automatic detection of any peripherals connected to the computer, either through direct contact or through a wired network.
  
• Automatically detects and controls connected Turbines/Reactors.
  
• Accepts connections to as many monitors and energy storage cubes as the network can support. (I haven't found the limit yet, if there is one.)
  
• Supports two monitors sizes: 1x2 and 2x3. (HxW)
  
• Supports billions of RF. Anything less than 1 trillion RF will fit on the screen.
  
• Features a capacity bar on the right side of the screen on 3v2 monitors.

Limitations:

• Only officially supports Energy Cells and Capacitor Banks. Mekanism Energy Cubes work, but aren't officially supported because they don't use RF. (They also only work if you have Computronics)
  
• Only officially reads RF, other types may be added in the future if there is demand.
  
• Can only control one turbine and one reactor. I could add support for more but I doubt anyone uses more than one of each.
  
• If you don't have Computronics then Capacitor Banks aren't fully supported. You must manually specify how many blocks are in the Capacitor Bank within the program and it only works properly for one Capacitor Bank. It may be inaccurate at times as well due to uneven RF distribution among the blocks of the Capacitor Bank.
  
• Requires at least one monitor and all monitors must be either 1x2 or 2x3 in size. I could add support for no monitors if needed.
  
• Can only output redstone to one side but I doubt that's an issue.

Suggestions:

I'm open to any and all suggestions, if there's a mod you want me to support or a new storage block or energy type you want it to read or feature you want me to add, please let me know.

Bugs:

I had to make a lot of changes to implement compatibility with both OpenPeripherals and Computronics and I haven't had time to fully test this version, so please consider version 1.3 beta until I've had time to fully test it. That being said I'm not currently aware of any bugs.

Planned Features:

• Anything possible/feasible that is suggested.

Get the code here: http://pastebin.com/cA2TNNdH

Read the Changelog/Readme here: http://pastebin.com/erPf3t4t

Background:

This script is based on one posted here.

I liked the idea of that script but I found it extremely lack-luster. It only supported one monitor and one energy storage block at a time, it only supported one monitor size, the redstone output side wasn't configurable and anything over a billion RF didn't fit on the screen. Oh yeah, and it didn't even work anymore with the current mod versions.

Enjoy!

This script was developed using Minecraft v1.7.10, Thermal Expansion 4.0.0RC7, EnderIO v2.2.8, Computercraft 1.73, Computronics v1.4.4 ,OpenPeripherals 1.7.10-AIO-2 and BigReactors 0.4.2A2.

Alright, I finished work on the updated script.

I've uploaded it here: http://pastebin.com/cA2TNNdH

I also uploaded a changelog of all the changes made from this original here: http://pastebin.com/erPf3t4t

The changes made are:

--Updated to work with current peripheral types (as of 1.7.10 and Thermal Expansion 4.0.0RC7 and EnderIO v2.2.8)
--Fixed spacing
--Formatted for 2x3 Monitor instead of 1x2
--Added formatting support for billions of RF
--Separated formatting of Current and Max RF values
--Made placement of RF values dynamic
--Made "of:" placement dynamic, it now places itself over the first digit of the Max value
--Added support for multiple connections to Capacitor Banks and Energy Cells, now accepts as many of each as you can connect to the network
--Added support for multiple monitors, now accepts as many monitors as you can connect to the network
--Added support for both 1x2 and 2x3 monitors with automatic detection and dynamic scaling for each
--Added support for Big Reactors' turbines and reactors. Only supports one of each.
--Added configurable redstone output side.

If you find any bugs or have any update suggestions, please be sure to let me know.

It looks to me as if this shouldn't work anymore, I ran peripheral.getType() on both a Capacitor Bank and an Energy Cell. The Capacitor Bank returned "capacitor_bank" and the energy cell returned "powered_tile".

The script looks for "tile_enderio_blockcapacitorbank_name" and "cofh_thermalexpansion_energycell". I don't know if peripherals return more than one type in an array, but if they don't then the types the scripts looks for should never be found and the program should always output "No Energy storage found. Halting script!"

Okay, I fixed it. The easiest way to fix it is to find and replace all instances of "tile_enderio_blockcapacitorbank_name" with "capacitor_bank" and all instances of "cofh_thermalexpansion_energycell" with "powered_tile". There are two instances of each. That is all that's required to make the script work.

However, I'm working on a much improved version of the script that adds support for billions of RF, formats the program to work on 2x3 monitors instead of 1x2 ones, fixes the spacing in the script, and much more.

chanzie, on 13 February 2015 - 01:24 PM, said:

No, it won't currently, but I'm revising the script and I'll see about adding support for it. Unless the cubes don't store RF or don't work with OpenPeripheralsIntegration, then it won't be possible.

Update: So I tried it out and Mekanisms Energy Cubes can be read by my script, but there's no way to differentiate them from TE4 Energy Cells, since they have the same peripheral type. This means that the script will connect to and read from Mekanism Energy Cubes, but they don't use RF so I can't officially support them.