mad, on 07 January 2013 - 07:51 AM, said:
This is just a topic, to show you all how badly Minecraft was written, paying NO attention to memory usage whatsoever.
This is just some code snippets:
Why add a bottleneck for no reason?
public void onUpdate()
{
this.onEntityUpdate();
}
I too, can't see a reason for this - however just because you can't see one, doesn't mean there is none. Could be a throwback from old code, for example.
mad, on 07 January 2013 - 07:51 AM, said:
Why so many bad and random method names??
public int getBlockTextureFromSideAndMetadata(int par1, int par2)
Epic fail much? Look what MCP actually does, and then go sulk in a corner.
mad, on 07 January 2013 - 07:51 AM, said:
Noo! What is he doing?
public static final Block[] blocksList = new Block[4096];
He's declaring an array to hold all the blocks in the game. Why is that a bad thing? Sure, there's other methods of holding items - but sometimes you don't need anything more complex than an array. And by "he" I assume you mean Mojang - Notch hasn't been a coder on Minecraft for a long time.
mad, on 07 January 2013 - 07:51 AM, said:
WHAT THE FLYING FUCK???
/** How much light is subtracted for going through this block */
public static final int[] lightOpacity = new int[4096];
/** Array of booleans that tells if a block can grass */
public static final boolean[] canBlockGrass = new boolean[4096];
/** Amount of light emitted */
public static final int[] lightValue = new int[4096];
public static final boolean[] requiresSelfNotify = new boolean[4096];
Again, I don't see the problem there. Care to show why you think it is a bad thing?
billysback, on 07 January 2013 - 10:44 AM, said:
although I agree that minecraft is badly written it is mainly in other ways;
his organization is appalling (no packets)
You do realise the obfuscation strips out packages (which I assume is what you meant) right?
billysback, on 07 January 2013 - 10:44 AM, said:
the way in which the world generates is very inefficient (he could have tried and made it generate the world in one loop of the blocks)
I'm not sure what you mean by this?
billysback, on 07 January 2013 - 10:44 AM, said:
he could have taken further consideration in to the possibility of multi-player support before he got too far in to the project
True - but great steps have now been made to make it truly a multiplayer game - even singleplayer is multiplayer!