Jump to content




[1.52] Turtles still can't place pistons correctly


11 replies to this topic

#1 Pharap

  • Members
  • 816 posts
  • LocationEngland

Posted 14 May 2013 - 02:03 PM

Turtles still place pistons the wrong way when placing them upwards.
If a turtle tries to place a piston upwards,it makes the piston face backwards instead of upwards like it should do.

#2 Cloudy

    Ex-Developer

  • Members
  • 2,543 posts

Posted 14 May 2013 - 03:37 PM

We never said we fixed it. Pistons placing code is stupid.

#3 Jarle212

  • Members
  • 198 posts
  • LocationNorway

Posted 14 May 2013 - 04:15 PM

View PostPharap, on 14 May 2013 - 02:03 PM, said:

Turtles still place pistons the wrong way when placing them upwards.
If a turtle tries to place a piston upwards,it makes the piston face backwards instead of upwards like it should do.
I think the pistons are placed based on the turtles direction(or viewing direction of placer) not where you place it

Edit: Whould be hard to fix

#4 Pharap

  • Members
  • 816 posts
  • LocationEngland

Posted 14 May 2013 - 08:28 PM

View PostJarle212, on 14 May 2013 - 04:15 PM, said:

I think the pistons are placed based on the turtles direction(or viewing direction of placer) not where you place it

Edit: Whould be hard to fix

Currently, pistons are placed so they always face the back of the turtle.
The ideal behaviour would be for the turtle to be able to choose which direction the piston faces,
but an easier solution that wouldn't require changing the workings of the place functions would be to make it so that pistons face downwards when placed down and upwards when placed up to allow the turtle the capability of placing pistons in all directions.


View PostCloudy, on 14 May 2013 - 03:37 PM, said:

We never said we fixed it. Pistons placing code is stupid.

I was assuming that was what the 1.51 "Fixed turtles sometimes placing blocks with incorrect orientations" fix was.
Is there a more in depth bug-fix log than the computercraft.info main page?

#5 Jarle212

  • Members
  • 198 posts
  • LocationNorway

Posted 16 May 2013 - 04:33 PM

View PostPharap, on 14 May 2013 - 08:28 PM, said:

Currently, pistons are placed so they always face the back of the turtle.
The ideal behaviour would be for the turtle to be able to choose which direction the piston faces,
but an easier solution that wouldn't require changing the workings of the place functions would be to make it so that pistons face downwards when placed down and upwards when placed up to allow the turtle the capability of placing pistons in all directions.

As I said pistons are place in the opposite direction of the turtles facing, and it is the same for players. You whould have to implement that function staticly, wich might break the code

#6 Pharap

  • Members
  • 816 posts
  • LocationEngland

Posted 16 May 2013 - 06:37 PM

View PostJarle212, on 16 May 2013 - 04:33 PM, said:

View PostPharap, on 14 May 2013 - 08:28 PM, said:

Currently, pistons are placed so they always face the back of the turtle.
The ideal behaviour would be for the turtle to be able to choose which direction the piston faces,
but an easier solution that wouldn't require changing the workings of the place functions would be to make it so that pistons face downwards when placed down and upwards when placed up to allow the turtle the capability of placing pistons in all directions.

As I said pistons are place in the opposite direction of the turtles facing, and it is the same for players. You whould have to implement that function staticly, wich might break the code

Well assuming that the part of the piston block that declares which way it's facing is editable by other classes, it shouldn't be that hard. It would only be an issue if the piston class forces the placement of the piston to be private, which shouldn't be the case as screwdrivers in RP2 are able to change the direction the block faces.

#7 rewind

  • Members
  • 5 posts

Posted 07 October 2013 - 04:19 PM

Has anyone already implemented a fix for this using a peripheral or some other means? I would love to be able to control the orientations of pistons at a minimum and other blocks as well when placing them. I just created a script generator to essentially 3d print designs from Excel and it is frustrating to pause it and place or reorient pistons because they won't face upwards.

#8 Booyaah

  • Members
  • 9 posts

Posted 12 October 2013 - 03:32 AM

View PostPharap, on 14 May 2013 - 08:28 PM, said:

make it so that pistons face downwards when placed down and upwards when placed up to allow the turtle the capability of placing pistons in all directions.

I would also very much like to be able to place pistons pointed up and down with turtles. I also wrote a 3D printing script but I'm unable to build anything that uses a piston pointed up or down so my automatic house building script and gate building script can't build the doors I want.

Would you consider making the piston face up when using turtle.placeUp()?

#9 rewind

  • Members
  • 5 posts

Posted 17 October 2013 - 09:57 AM

View PostBooyaah, on 12 October 2013 - 03:32 AM, said:

Would you consider making the piston face up when using turtle.placeUp()?

This post presents a better solution: http://www.computerc...th-placeupdown/

The developers seem to be apprehensive to it, though. Maybe I can look further into it in the future, but I would need to start from the beginning learning to decompile and modify, etc. It would have to wait until I get some precious free time since I see the learning curve taking a day or two's worth of work.

#10 Cloudy

    Ex-Developer

  • Members
  • 2,543 posts

Posted 17 October 2013 - 10:14 PM

View Postrewind, on 17 October 2013 - 09:57 AM, said:

View PostBooyaah, on 12 October 2013 - 03:32 AM, said:

Would you consider making the piston face up when using turtle.placeUp()?

This post presents a better solution: http://www.computerc...th-placeupdown/

The developers seem to be apprehensive to it, though. Maybe I can look further into it in the future, but I would need to start from the beginning learning to decompile and modify, etc. It would have to wait until I get some precious free time since I see the learning curve taking a day or two's worth of work.

You wouldn't be permitted to release it - so I wouldn't waste your time.

#11 rewind

  • Members
  • 5 posts

Posted 19 October 2013 - 09:39 AM

View PostCloudy, on 17 October 2013 - 10:14 PM, said:

You wouldn't be permitted to release it - so I wouldn't waste your time.

Classy

#12 Cranium

    Ninja Scripter

  • Moderators
  • 4,031 posts
  • LocationLincoln, Nebraska

Posted 21 October 2013 - 09:58 AM

View Postrewind, on 19 October 2013 - 09:39 AM, said:

Classy
Don't complain. Cloudy and Dan have always said you're free to edit the files to any extent you'd like for personal enlightenment. However, you're not allowed to redistribute edited versions of the mod.





1 user(s) are reading this topic

0 members, 1 guests, 0 anonymous users